Skip to content

Add test cases for JSON resource marshaling#2524

Merged
gmlewis merged 4 commits intogoogle:masterfrom
sayalideshmukh10:test_case_scim
Oct 25, 2022
Merged

Add test cases for JSON resource marshaling#2524
gmlewis merged 4 commits intogoogle:masterfrom
sayalideshmukh10:test_case_scim

Conversation

@sayalideshmukh10
Copy link
Copy Markdown
Contributor

@sayalideshmukh10 sayalideshmukh10 commented Oct 25, 2022 •
edited by gmlewis
Loading

Added test cases for the below structs - github/scim.go (file)

  1. UpdateAttributeForSCIMUserOperations
  2. UpdateAttributeForSCIMUserOptions
  3. ListSCIMProvisionedIdentitiesOptions

Helps: #55.

gmlewis
gmlewis requested changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sayalideshmukh10 .
We might as well make the formatting of the wanted JSON consistent and easy-to-read, as if it were created by a JSON indented marshaler.

@gmlewis gmlewis changed the title Added test cases for JSON resource marshaling Add test cases for JSON resource marshaling Oct 25, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #2524 (97dd774) into master (3cb9c66) will not change coverage.
The diff coverage is n/a.

❗ Current head 97dd774 differs from pull request most recent head faaaa0c. Consider uploading reports for the commit faaaa0c to get more accurate results

@@           Coverage Diff           @@
##           master    #2524   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sayalideshmukh10
Copy link
Copy Markdown
Contributor Author

sayalideshmukh10 commented Oct 25, 2022

Hello @gmlewis,
I addressed all review comments

I am a first-time contributor to Hackoctober, It will be a great help if you can accept my contribution.

gmlewis
gmlewis approved these changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sayalideshmukh10 !
Before we merge, would you like to resolve the conflicts with the recent merges to the master branch, or would you like me to do it?

@sayalideshmukh10
Copy link
Copy Markdown
Contributor Author

sayalideshmukh10 commented Oct 25, 2022

Thank you @gmlewis for asking about merging conflicts and resolving
I already resolved the merge conflicts kindly look into it

@gmlewis gmlewis merged commit 33c3e88 into google:master Oct 25, 2022
Harikesh00 pushed a commit to Harikesh00/go-github that referenced this pull request Oct 25, 2022
@sayalideshmukh10 @Harikesh00
Add test cases for JSON resource marshaling (google#2524)
863155e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sayalideshmukh10 @gmlewis