Merge branch 'master' of https://github.com/sayalideshmukh10/go-github into test_case_scim

sayalideshmukh10 · sayalideshmukh10 · commit faaaa0c68abb · 2022-10-25T10:42:58.000-04:00
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -20,7 +20,7 @@ jobs:
       contents: read  # for actions/checkout to fetch code
     strategy:
       matrix:
-        go-version: [1.x, 1.17.x]
+        go-version: [1.x, 1.18.x]
         platform: [ubuntu-latest]
         include:
           # include windows, but only with the latest Go version, since there
diff --git a/README.md b/README.md
@@ -123,10 +123,10 @@ GitHub Apps authentication can be provided by the [ghinstallation](https://githu
 package.
 
 > **Note**: Most endpoints (ex. [`GET /rate_limit`]) require access token authentication
-> while a few others (ex. [`GET /app/hook/deliverires`]) require [JWT] authentication.
+> while a few others (ex. [`GET /app/hook/deliveries`]) require [JWT] authentication.
 
 [`GET /rate_limit`]: https://docs.github.com/en/rest/rate-limit#get-rate-limit-status-for-the-authenticated-user
-[`GET /app/hook/deliverires`]: https://docs.github.com/en/rest/apps/webhooks#list-deliveries-for-an-app-webhook
+[`GET /app/hook/deliveries`]: https://docs.github.com/en/rest/apps/webhooks#list-deliveries-for-an-app-webhook
 [JWT]: https://docs.github.com/en/developers/apps/building-github-apps/authenticating-with-github-apps#authenticating-as-a-github-app
 
 
diff --git a/github/scim_test.go b/github/scim_test.go
@@ -445,3 +445,22 @@ func TestListSCIMProvisionedIdentitiesOptions_Marshal(t *testing.T) {
 
 	testJSONMarshal(t, u, want)
 }
+
+func TestSCIMUserName_Marshal(t *testing.T) {
+	testJSONMarshal(t, &SCIMUserName{}, `{
+		"givenName":"","familyName":""
+	}`)
+
+	u := &SCIMUserName{
+		GivenName:  "Name1",
+		FamilyName: "Fname",
+		Formatted:  String("formatted name"),
+	}
+
+	want := `{
+			"givenName": "Name1",
+			"familyName": "Fname",
+			"formatted": "formatted name"	
+	}`
+	testJSONMarshal(t, u, want)
+}
diff --git a/github/teams_test.go b/github/teams_test.go
@@ -2098,3 +2098,39 @@ func TestTeamsService_RemoveConnectedExternalGroup_notFound(t *testing.T) {
 		t.Errorf("Teams.GetExternalGroup returned status %d, want %d", got, want)
 	}
 }
+
+func TestIDPGroupList_Marshal(t *testing.T) {
+	testJSONMarshal(t, &IDPGroupList{}, "{}")
+
+	u := &IDPGroupList{
+		Groups: []*IDPGroup{
+			{
+				GroupID:          String("abc1"),
+				GroupName:        String("test group"),
+				GroupDescription: String("test group descripation"),
+			},
+			{
+				GroupID:          String("abc2"),
+				GroupName:        String("test group2"),
+				GroupDescription: String("test group descripation2"),
+			},
+		},
+	}
+
+	want := `{
+		"groups": [
+			{
+				"group_id": "abc1",
+				"group_name": "test group",
+				"group_description": "test group descripation"
+			},
+			{
+				"group_id": "abc2",
+				"group_name": "test group2",
+				"group_description": "test group descripation2"
+			}
+		]
+	}`
+
+	testJSONMarshal(t, u, want)
+}
