Escape special characters in ref name for update ref#2454
Escape special characters in ref name for update ref#2454gmlewis merged 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2454 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10689 10689
=======================================
Hits 10479 10479
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @shravan1k !
Please add a unit test that demonstrates this change in functionality.
gmlewis
left a comment
There was a problem hiding this comment.
Whups - checked the wrong box.
Thank you, @shravan1k !
Please add a unit test that demonstrates this change in functionality.
gmlewis
left a comment
There was a problem hiding this comment.
Beautiful, @shravan1k ! Thank you!
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
|
Thank you, @marcelosousa ! |
Closes #2453
Most of the functions that deal with refs make sure to escape the special characters within the ref's name. The
UpdateReffunction doesn't seem to call the function that does this substitution of special characters with their encodings. This PR solves this problem and should now successfully patch remote refs if theGetReffunction says the corresponding ref exists.