Re-disable scheduled jobs on forks#537
Merged
Swatinem merged 1 commit intoJan 16, 2023
Merged
Conversation
I disabled scheduled jobs on forks in getsentry#435 to prevent [unnecessary spam from steps that are not supposed to succeed anyway], but @Swatinem removed the check in getsentry#528 for an undocumented reason. Add it back to not bother forkers with day-to-day issues, while still allowing them to test/see CI results locally on push (to one of a limited set of preconfigured branches). [unnecessary spam from steps that are not supposed to succeed anyway]: https://github.com/MarijnS95/sentry-rust/actions/runs/3926205216
Swatinem
approved these changes
Jan 16, 2023
Swatinem
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding these back!
Might be a good idea to add a comment why that check exists, so next time someone comes around cleaning up the actions, they won’t remove these again.
Contributor
|
:-D Might have been too overeager merging this. I think I will do a quick |
Contributor
Author
|
These statements seem rather self-explanatory to me, but sure I can add some comments... if it wasn't ninja-merged before pushing those :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disabled scheduled jobs on forks in #435 to prevent unnecessary spam from steps that are not supposed to succeed anyway, but @Swatinem removed the check in #528 for an undocumented reason. Add it back to not bother forkers with day-to-day issues, while still allowing them to test/see CI results locally on push (to one of a limited set of preconfigured branches).