Conversation
Swatinem
commented
Nov 29, 2022
Contributor
- Update actions versions.
- Switch to cargo-llvm-cov.
- Update actions versions. - Switch to cargo-llvm-cov.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 78.84% 69.66% -9.18%
==========================================
Files 77 66 -11
Lines 9355 6554 -2801
==========================================
- Hits 7376 4566 -2810
- Misses 1979 1988 +9 |
Contributor
Author
|
The "regression" in code coverage is primarily because we are not considering doctests for coverage anymore. Sentry-rust relies on doctests a lot compared to straight unit/integration tests. |
kamilogorek
approved these changes
Nov 29, 2022
MarijnS95
added a commit
to MarijnS95/sentry-rust
that referenced
this pull request
Jan 16, 2023
I disabled scheduled jobs on forks in getsentry#435 to prevent [unnecessary spam from steps that are not supposed to succeed anyway], but @Swatinem removed the check in getsentry#528 for an undocumented reason. Add it back to not bother forkers with day-to-day issues, while still allowing them to test/see CI results locally on push (to one of a limited set of preconfigured branches). [unnecessary spam from steps that are not supposed to succeed anyway]: https://github.com/MarijnS95/sentry-rust/actions/runs/3926205216
Swatinem
pushed a commit
that referenced
this pull request
Jan 16, 2023
I disabled scheduled jobs on forks in #435 to prevent [unnecessary spam from steps that are not supposed to succeed anyway], but @Swatinem removed the check in #528 for an undocumented reason. Add it back to not bother forkers with day-to-day issues, while still allowing them to test/see CI results locally on push (to one of a limited set of preconfigured branches). [unnecessary spam from steps that are not supposed to succeed anyway]: https://github.com/MarijnS95/sentry-rust/actions/runs/3926205216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.