sentry-core: make TransactionContext.trace_id readable#533
Conversation
kamilogorek
left a comment
There was a problem hiding this comment.
This is already possible in JS SDK, so I don't see a reason why it shouldn't be here.
Agreed, thanks. I already access Note that this PR only exposes it on the |
cc @Swatinem |
|
IMO its a good idea to also expose that on the |
I'm happy to pick this up as a subsequent PR. The simplest option would be to expose the sentry-rust/sentry-types/src/protocol/v7.rs Line 1439 in 5013eb1 Alternatively I could look at exposing the fields individually, which would be quite boilerplate heavy. |
|
Opened a separate PR for exposing on the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 69.69% 69.66% -0.04%
==========================================
Files 66 66
Lines 6561 6564 +3
==========================================
Hits 4573 4573
- Misses 1988 1991 +3 |
|
Is there a scheduled release cadence for the sentry family of crates? Would like to know when a release with this in is likely to be cut |
|
We don’t have a fixed cadence, rather adhoc. I triggered the automated release which needs to be approved and should be out shortly: getsentry/publish#1766 |
|
Amazing, thank you |
I would like to add the Sentry trace_id to our internal logs to be able to correlate it with the sentry transaction. Currently this isn't publicly accessible anywhere.