Codecov Report

Merging #534 (e65304d) into master (abc2b34) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head e65304d differs from pull request most recent head a15b835. Consider uploading reports for the commit a15b835 to get more accurate results

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   69.66%   69.53%   -0.14%     
==========================================
  Files          66       66              
  Lines        6564     6577      +13     
==========================================
  Hits         4573     4573              
- Misses       1991     2004      +13     

its a bit unfortunate this is behind a lock so you need to clone :-(

but oh well

Agreed. I think in future there would be scope for handling this better with something like parking_lot's MutexGuard::map, if you're open to changing the implementation of Mutex: https://docs.rs/lock_api/latest/lock_api/struct.MutexGuard.html#method.map

But I think for this case, a one-off clone is not too bad.

I would be hesitant to give out more lock guards, with the recent deadlock I tracked down and fixed quite painfully: #536

We should rather remove the need for locking in the first place somehow, though I have no good ideas at the moment.