fix: Avoid Deadlock popping ScopeGuards out of order#536
Merged
Conversation
The `ScopeGuard` panics when it is being dropped out of order. Previously it would do so while holding the Scope/stack `RwLock`. The `PanicIntegration` would also try to acquire that same lock in order to capture the resulting panic, resulting in a deadlock or a double-panic in case the `RwLock` implementation detected the deadlock.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 69.53% 71.01% +1.48%
==========================================
Files 66 66
Lines 6577 6575 -2
==========================================
+ Hits 4573 4669 +96
+ Misses 2004 1906 -98 |
loewenheim
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ScopeGuardpanics when it is being dropped out of order. Previously it would do so while holding the Scope/stackRwLock. ThePanicIntegrationwould also try to acquire that same lock in order to capture the resulting panic, resulting in a deadlock or a double-panic in case theRwLockimplementation detected the deadlock.