feat(angular): Export custom browserTracingIntegration()#10353
Merged
feat(angular): Export custom browserTracingIntegration()#10353
browserTracingIntegration()#10353Conversation
Contributor
size-limit report 📦
|
ed19b05 to
af7fc5c
Compare
Lms24
reviewed
Jan 26, 2024
Lms24
approved these changes
Jan 26, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Nice! I think this is cleaner than the initial approach.
Base automatically changed from
fn/newBrowserTracingIntegrationOnly
to
develop
January 26, 2024 15:54
6bb58b7 to
30db58f
Compare
Member
Author
|
This is now "ready" - @Lms24 could you maybe try this with an actual angular app, just to verify if it really works 😅 |
Member
|
@mydea yup we should do that. Actually, this is a good opportunity for adding an e2e test app. Will spend some time on this today. |
30db58f to
4a52c27
Compare
mydea
commented
Jan 30, 2024
packages/angular/src/tracing.ts
Outdated
| ): Integration { | ||
| // If the user opts out to set this up, we just don't initialize this. | ||
| // That way, the TraceService will not actually do anything, functionally disabling this. | ||
| if (options.instrumentNavigation === false) { |
Member
Author
There was a problem hiding this comment.
I figured this is good enough to allow users to disable this. It means that if users do this:
browserTracingIntegration({ instrumentNavigation: false })- add the TraceService, they will get the warning "Angular integration has tracing enabled, but Tracing integration is not configured". Id' say that's good enough?
4a52c27 to
8367a00
Compare
8909607 to
b290582
Compare
Also deprecate the routing Instrumentation.
fe7d870 to
4d3828b
Compare
s1gr1d
added a commit
that referenced
this pull request
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also deprecate the routing Instrumentation.
This is WIP on top of #10351, to show how that would work.
No idea how to get the tests working for this, though...