ref(v8/angular): Remove instrumentAngularRouting and fix tests#11021
Merged
ref(v8/angular): Remove instrumentAngularRouting and fix tests#11021
Conversation
52cc527 to
2c35d91
Compare
Lms24
reviewed
Mar 11, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Nice, just had two small suggestions but looks great!
| expect.objectContaining({ | ||
| name: '<ComponentTrackingComponent>', | ||
| op: 'ui.angular.ngOnInit', | ||
| attributes: { [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.angular.trace_class_decorator' }, |
Member
There was a problem hiding this comment.
should this be trace_method_decorator
Comment on lines
+230
to
+237
| const initSpan = navigationTxn.spans?.find(span => span.op === 'ui.angular.init'); | ||
|
|
||
| expect(initSpan).toBeDefined(); |
Member
There was a problem hiding this comment.
can we also check for the origin attribute here?
| imports: [TraceModule, SampleComponent], | ||
| template: `<app-sample-component [trace]="'sample-component'"></app-sample-component>`, | ||
| }) | ||
| @TraceClassDecorator() |
Member
There was a problem hiding this comment.
random thought (no action required):
We should probably omit the "Decorator" part in both decorator names.@TraceClass and @TraceMethod makes more sense IMO.
Member
Author
There was a problem hiding this comment.
True, the usage already implies that it is a decorator
2c35d91 to
3dc88a6
Compare
3dc88a6 to
1cd1a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #10898
ref #10353