feat(core): Deprecate Span.isSuccess() in favor of reading span status#10213
Merged
feat(core): Deprecate Span.isSuccess() in favor of reading span status#10213
Span.isSuccess() in favor of reading span status#10213Conversation
Span.isSuccess in favor of reading span statusSpan.isSuccess() in favor of reading span status
15d55ad to
172fa2a
Compare
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 17, 2024
172fa2a to
0af1aeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Span.isSuccess()in favor of directly reading the span status viaspanToJSON(span).status === 'ok'instead. There's no need for this API as it's just syntactic sugar around the status.Seemed like we didn't even use this API in our SDKs - maybe some downstream SDKs use it but migrating should be very straightforward.
ref #10184