Skip to content

feat(v8): Remove deprecated span.isSuccess method#10699

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-isSuccess
Feb 20, 2024
Merged

feat(v8): Remove deprecated span.isSuccess method#10699
AbhiPrasad merged 1 commit intodevelopfrom
abhi-isSuccess

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Feb 16, 2024

ref #10677

deprecation PR: #10213

@AbhiPrasad AbhiPrasad requested a review from a team February 16, 2024 20:11
@AbhiPrasad AbhiPrasad self-assigned this Feb 16, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and stephanie-anderson and removed request for a team February 16, 2024 20:11
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 16, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.92 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.17 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.1 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.76 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.37 KB (-0.05% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.27 KB (-0.04% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.21 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.22 KB (0%)
@sentry/browser - Webpack (gzipped) 22.47 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.26 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.79 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.74 KB (-0.03% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.8 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.3 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.92 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.33 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.91 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.52 KB (-0.03% 🔽)
@sentry/react - Webpack (gzipped) 22.5 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.03 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.21 KB (-0.03% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.2 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 3b9c37e into develop Feb 20, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-isSuccess branch February 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-javascript-sdks

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad @lforst