Merged
Conversation
This reverts commit f4f7c8e.
aldy505
reviewed
Mar 25, 2024
aldy505
approved these changes
Mar 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 81.93% 81.96% +0.03%
==========================================
Files 48 49 +1
Lines 4782 4846 +64
==========================================
+ Hits 3918 3972 +54
- Misses 725 732 +7
- Partials 139 142 +3 ☔ View full report in Codecov by Sentry. |
vaind
suggested changes
Mar 26, 2024
Contributor
vaind
left a comment
There was a problem hiding this comment.
looks pretty good to me. Can you please add the missing tests for wait+timeout and cookies? See https://app.codecov.io/gh/getsentry/sentry-go/pull/795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry
Closed
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
reviewed
Mar 26, 2024
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
approved these changes
Mar 26, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiber integration
These are just fixes and master merged on the #273. Since the fork was deleted, I was unable to push to it without some shenanigans thus opted for creating a new PR.
Resolves #441.
Might also reach to Fiber as they provide the same integration at https://github.com/gofiber/contrib/tree/main/fibersentry.