fix: missing stack trace for parsing error in logrusentry#689
Merged
ribice merged 8 commits intogetsentry:masterfrom Apr 2, 2024
Merged
fix: missing stack trace for parsing error in logrusentry#689ribice merged 8 commits intogetsentry:masterfrom
ribice merged 8 commits intogetsentry:masterfrom
Conversation
4c84592 to
5caf94e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 82.06% 82.01% -0.05%
==========================================
Files 49 49
Lines 4872 4844 -28
==========================================
- Hits 3998 3973 -25
+ Misses 732 730 -2
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
I added the changes from RFC 0079 (parent_id, exception_id and is_exception_group). Apart from that this PR fixed the issue with missing stacktrace. Once #792 is merged as well, I'll create a common function for extracting errors and creating exceptions so that it's not rewritten wherever needed. |
vaind
previously requested changes
Mar 26, 2024
cleptric
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #677