Add support for errors.Unwrap() in SetException#792
Merged
ribice merged 12 commits intogetsentry:masterfrom Mar 26, 2024
ribice:master
Merged
Add support for errors.Unwrap() in SetException#792ribice merged 12 commits intogetsentry:masterfrom ribice:master
ribice merged 12 commits intogetsentry:masterfrom
ribice:master
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 81.97% 82.06% +0.08%
==========================================
Files 49 49
Lines 4848 4872 +24
==========================================
+ Hits 3974 3998 +24
Misses 732 732
Partials 142 142 ☔ View full report in Codecov by Sentry. |
cleptric
previously approved these changes
Mar 12, 2024
cleptric
reviewed
Mar 12, 2024
cleptric
reviewed
Mar 13, 2024
cleptric
reviewed
Mar 13, 2024
cleptric
reviewed
Mar 13, 2024
cleptric
reviewed
Mar 13, 2024
aldy505
reviewed
Mar 25, 2024
aldy505
approved these changes
Mar 25, 2024
vaind
reviewed
Mar 26, 2024
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
approved these changes
Mar 26, 2024
Contributor
vaind
left a comment
There was a problem hiding this comment.
LGTM after a changelog entry is added
vaind
approved these changes
Mar 26, 2024
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for handling errors using errors.Unwrap() in SetException.
Add ParentID, ExceptionID and Source to Exception.
Related issue: #693
RFC