Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/eui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v84.0.0
Choose a base ref
...
head repository: elastic/eui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v85.0.0
Choose a head ref
  • 16 commits
  • 1,042 files changed
  • 8 contributors

Commits on Jul 11, 2023

  1. Updated documentation.

    cee-chen committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b37980e View commit details
    Browse the repository at this point in the history
  2. [EuiStepsHorizontal] Create size prop to generate smaller step circ…

    …les for horizontal steps (#6928)
    
    * [EuiStepsHorizontal] Add size prop that generates a smaller step circle for horizontal steps
    
    * [EuiStepsHorizontal] Add documentation for new size prop
    
    * [EuiStepsHorizontal] Update snapshot test and add new test for size prop
    
    * Changelog
    
    * Whoops! Wrong changelog number
    
    * Update src/components/steps/step_horizontal.styles.ts
    
    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    
    * [PR Feedback] Make the internal step size and inset generation flexible.
    
    * Update upcoming_changelogs/6928.md
    
    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    breehall and cee-chen authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    264892f View commit details
    Browse the repository at this point in the history
  3. [CI] Remove non-working bash script / npx semver (#6931)

    * Remove non-working bash script / `npx semver`
    
    * Move debug echoes around to match usage/definitions
    
    - let's just leave them in permanently for future debugging
    
    * Remove if template literals
    
    - no longer needed, new git describe returns the `v` as expected
    
    * [??] Remove `docker run/` script around the git tag fetch
    
    * [PR feedback] shellcheck
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    
    * [PR feedback] shellcheck
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    cee-chen and 1Copenut authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d58f3ce View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. [EuiDataGrid] Use integer values for dimensions derived from integers (

    …#6895)
    
    * Use integer values for dimensions derived from integers
    
    * Separate grid height and width rerenders/recalulations
    
    - this appears to be causing at least 50% of the problem / making height recalculate when only width should update, and vice versa
    
    * Round both `wrapperHeight` and `unconstrainedHeight` to nearest integer
    
    - from my zoom testing, *both* can have annoying decimal behavior, and rounding both solves the issue
    
    * changelog
    
    ---------
    
    Co-authored-by: Cee Chen <constance.chen@elastic.co>
    kqualters-elastic and cee-chen authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    edc7062 View commit details
    Browse the repository at this point in the history
  2. [EuiTab] Fix prepend/append elements not inheriting selected colors +…

    … misc CSS cleanup (#6938)
    
    * Fix EuiTab icons not inheriting the selected color
    
    * Clean up tab CSS to reduce unnecessary color setting/overrides
    
    - Using the `euiTitle()` util gives us too much we don't need (color, font-weight, etc.) - it makes more sense to simply use `euiFontSize` directly
    
    - doing so allows us to set `color` once on the parent button
    
    * More CSS cleanup
    
    - focus and hover styles aren't necessary or doing anything - remove them
    
    * Update snapshots
    
    * changelog
    cee-chen authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5adce56 View commit details
    Browse the repository at this point in the history
  3. [Emotion] Publicly export cloneElementWithCss service/util (#6939)

    * Move `cloneElementWithCss` util to its own folder
    
    - it's fairly Emotion specific and not EUI theme specific, so should probably be in its own service folder
    
    + export as top-level export & remove comment
    
    * Update internal EUI usages of `cloneElementWithCss`
    
    * changelog
    cee-chen authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d9b2dc3 View commit details
    Browse the repository at this point in the history
  4. [Wiki] Document prerelease RC process (#6927)

    * Add a prerelease process section to our wiki docs
    
    * [PR feedback] Copy
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    cee-chen and 1Copenut authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ad4880a View commit details
    Browse the repository at this point in the history
  5. [Emotion] Add Emotion theming support (#6913)

    * [setup] Move dev provider warnings to its own file
    
    - this is necessary to prevent webpack circular dependency errors when trying to call `useEuiTheme()` from anything imported by `provider.tsx` (even though it's valid usage)
    
    * Set up Emotion ThemeProvider + types
    
    * Add unit tests
    
    * Add documentation warning against internal usage
    
    * Add consumer-facing documentation
    
    * changelog
    
    * [PR feedback] Copy
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    cee-chen and 1Copenut authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f61e640 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. at & key Icon Glyphs (#6934)

    * add `at` and `key` icon glyphs
    
    * update snapshots
    
    * add changelog
    
    ---------
    
    Co-authored-by: Michael Marcialis <michael@marcial.is>
    MichaelMarcialis and Michael Marcialis authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    abde51b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. [EuiProvider] Add a check and dev warning+early return for nested usa…

    …ge (#6949)
    
    * [setup] DRY out warning logic and write more robust unit tests for it
    
    * [cleanup] Move `EuiThemeProvider` nested tests to theme provider file
    
    - they don't really belong in `EuiProvider`
    
    * [cleanup] Improve EuiThemeProvider's unit testing
    
    - make `EuiProvider`s tests more basic in comparison
    
    - use `toHaveStyleRule` instead of snapshots
    
    * [cleanup] Convert more EuiProvider tests to RTL from Enzyme
    
    * [cleanup] Convert `EuiProvider` cache tests to RTL from Enzyme
    
    * Set up a context to check for nested `EuiProvider`s
    
    * Update `EuiProvider` to return early and emit a warning if nested usage is detected
    
    * Fix types on EuiProvider's props table
    
    * [docs] Improve `EuiProvider` and `EuiThemeProvider` docs
    
    - clarify in as many places as possible
    
    - remove uncertain language (e.g. 'currently', 'future') that were still not yet figured out when docs were written
    
    - try to remove overlap in docs between provider and theme provider, try to clarify nested usage of theme provider
    
    - add examples to warning section
    
    * changelog
    
    * Fix Cypress tests failing due to nested EuiProviders
    
    * [PR feedback] Allow `cy.mount` to have a configurable provider props
    cee-chen authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    42ecae5 View commit details
    Browse the repository at this point in the history
  2. [CHORE] Adding a temp Jenkins env variable for the migration. (#6950)

    * Adding a temp Jenkins env variable for the migration.
    * Adding JENKINS_CI env variable to deploy_docs job.
    1Copenut authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3530035 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. [EuiPopover][EuiInputPopover] Allow more control via focusTrapProps (

    …#6955)
    
    * Give consumers more control over `focusTrapProps`
    
    - the number of consumers with edge cases / enough knowledge to start overriding props is going to be very small, and they should be allowed to do so if needed
    
    * Remove `onTrapDeactivation` prop in favor of `focusTrapProps.onDeactivation`
    
    * changelog
    
    * [EuiInputPopover] Extend same `focusTrapProps` flexibility
    
    - this is more of a bugfix IMO since this should have been working before
    cee-chen authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2228bef View commit details
    Browse the repository at this point in the history
  2. [Emotion] Convert EuiFilterGroup and EuiFilterButton (#6957)

    * Move Amsterdam overrides to source CSS
    
    * Set up basic Emotion styles
    
    * Convert compressed styles
    
    * Convert fullWidth and responsive styles
    
    * Convert remaining child EuiFilterGroup styles
    
    - flattening out as much CSS as possible to EuiFilterButton
    
    - styles targeting popover/tooltip wrappers can't be targeted, but we can at least avoid euiFilterButtons receiving those styles with a DRY util and a `:not` selector
    
    * Convert `.euiFilterGroup__popoverPanel` to Emotion
    
    TODO: Kibana usages will need to be converted to a `css` prop as well, and import the styles fn directly
    
    * Convert more EuiButtonFilter + borders
    
    - DRY out box-shadow CSS, add more comments
    
    * Convert more EuiButtonFilter modifier classes
    
    * Convert EuiFilterButton disabled/hover styles
    
    - remove disabled styles - just use EuiButtonEmpty's default styles instead
    
    - non-disabled styles still need to be converted despite grody nesting levels :T
    
    * Convert EuiFilterButton child styles to Emotion
    
    + misc JS syntax cleanup
    
    + DRY out `hasNotification` condition - should be using `showBadge` instead
    
    content:
    - flatten `hasIcon` CSS
    
    text:
    - add missing parent `.euiFilterButton__text` className on textprops
    
    notification:
    - remove unnecessary vertical-align (no effect since flex is already doing its thing)
    - switch to gap instead of margin for spacing
    - flatten disabled opacity styles
    
    * [misc cleanup] DRY out `dataText`
    
    * [opinionated] Improve focus/hover states of child EuiFilterButtons
    
    - (focus) add manually border radius rounding logic - it's verbose (due to popover anchors) but visually worth it
    
    - (hover) force the notification badge to inherit both interactive and disabled cursors
    
    * Delete Sass files
    
    * Convert tests to RTL
    
    * Update downstream snapshots
    
    * Add Storybook stories
    
    * changelog
    
    * Fix responsive wrapping behavior
    
    - just use `euiMaxBreakpoint` instead of `euiBreakpoints`, the concept of "s and under" is easier to follow
    cee-chen authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    35e30ec View commit details
    Browse the repository at this point in the history
  3. update i18ntokens

    tkajtoch committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f45dbba View commit details
    Browse the repository at this point in the history
  4. Updated changelog.

    tkajtoch committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    60ce92f View commit details
    Browse the repository at this point in the history
  5. 85.0.0

    tkajtoch committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f771bfa View commit details
    Browse the repository at this point in the history
Loading