feat: Add the names of tables to the periodic logger#738
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom May 30, 2023
shimonp21:feat_log_tables
Merged
feat: Add the names of tables to the periodic logger#738kodiakhq[bot] merged 6 commits intocloudquery:mainfrom shimonp21:feat_log_tables
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
shimonp21:feat_log_tables
Conversation
⏱️ Benchmark resultsComparing with f5f7cd7
|
erezrokah
requested changes
Mar 27, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the PR @shimonp21, added a couple of comments
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 47.52% 47.65% +0.12%
==========================================
Files 55 55
Lines 5176 5078 -98
==========================================
- Hits 2460 2420 -40
+ Misses 2453 2408 -45
+ Partials 263 250 -13
☔ View full report in Codecov by Sentry. |
erezrokah
reviewed
Mar 27, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the follow up @shimonp21, added a few more comments
disq
requested changes
Mar 27, 2023
if the number of running tables is small (less than e.g. 30), log all their names in the periodic 'sync in progress' logs.
disq
approved these changes
Mar 28, 2023
hermanschaaf
reviewed
Apr 4, 2023
hermanschaaf
approved these changes
May 24, 2023
yevgenypats
approved these changes
May 30, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- ## [3.8.0](v3.7.0...v3.8.0) (2023-05-31) ### Features * Add the names of tables to the periodic logger ([#738](#738)) ([72e1d49](72e1d49)) * Separate Queued Tables from In Progress Tables ([#920](#920)) ([dcb5d26](dcb5d26)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the number of running tables is small (less than e.g. 30), log all their names in the periodic 'sync in progress' logs.
Example log lines:
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)