feat: Separate Queued Tables from In Progress Tables#920
Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom May 31, 2023
Merged
feat: Separate Queued Tables from In Progress Tables#920kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
Conversation
disq
reviewed
May 30, 2023
disq
approved these changes
May 30, 2023
⏱️ Benchmark resultsComparing with 72e1d49
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 47.89% 48.00% +0.11%
==========================================
Files 55 55
Lines 5226 5245 +19
==========================================
+ Hits 2503 2518 +15
- Misses 2460 2464 +4
Partials 263 263
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
May 31, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- ## [3.8.0](v3.7.0...v3.8.0) (2023-05-31) ### Features * Add the names of tables to the periodic logger ([#738](#738)) ([72e1d49](72e1d49)) * Separate Queued Tables from In Progress Tables ([#920](#920)) ([dcb5d26](dcb5d26)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users limit the concurrency of their sync, tables that have not been started will appear to be "in-progress" even though they are waiting to start...
This PR separates
queuedtables fromin-progressby definingin-progresstables as those that have noend-time, but do have a non-zero start time.queuedtables are those tables that have a zero start and end time