fix(destination): Pass proper spec to client constructor#606
Merged
kodiakhq[bot] merged 3 commits intomainfrom Jan 16, 2023
Merged
fix(destination): Pass proper spec to client constructor#606kodiakhq[bot] merged 3 commits intomainfrom
kodiakhq[bot] merged 3 commits intomainfrom
Conversation
⏱️ Benchmark results
|
hermanschaaf
approved these changes
Jan 16, 2023
yevgenypats
approved these changes
Jan 16, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 16, 2023
🤖 I have created a release *beep* *boop* --- ## [1.26.0](v1.25.1...v1.26.0) (2023-01-16) ### Features * **destinations:** Add `migrate_mode` ([#604](#604)) ([78b9acb](78b9acb)) ### Bug Fixes * **destination:** Pass proper spec to client constructor ([#606](#606)) ([8370882](8370882)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 18, 2023
Implements #6145. Depends on: * cloudquery/plugin-sdk/pull/585 * cloudquery/plugin-sdk/pull/606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass the correct spec to the client constructor.
Currently, we set defaults on
p.spec, but passspecthat can be not initialized properly.