feat(transformers): Add support for net.IP#595
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Jan 11, 2023
Merged
feat(transformers): Add support for net.IP#595kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
net.IP#595kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark resultsComparing with 506d4cc
|
candiduslynx
approved these changes
Jan 11, 2023
Co-authored-by: candiduslynx <candiduslynx@users.noreply.github.com>
612ce13 to
81db845
Compare
hermanschaaf
approved these changes
Jan 11, 2023
|
|
||
| func defaultGoTypeToSchemaType(v reflect.Type) (schema.ValueType, error) { | ||
| // Non primitive types | ||
| if v == reflect.TypeOf(net.IP{}) { |
Contributor
There was a problem hiding this comment.
Should it maybe go with time.Time under the struct case?
Member
Author
There was a problem hiding this comment.
In the switch it falls under reflect.Slice (it's a byte array), but it feels odd to check the kind then again the type
Contributor
There was a problem hiding this comment.
Ah I see, yeah. Makes sense 👍
candiduslynx
approved these changes
Jan 11, 2023
yevgenypats
approved these changes
Jan 11, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
🤖 I have created a release *beep* *boop* --- ## [1.25.0](v1.24.2...v1.25.0) (2023-01-11) ### Features * **docs:** Sort tables ([#599](#599)) ([8a3bfad](8a3bfad)) * **transformers:** Add support for `net.IP` ([#595](#595)) ([a420645](a420645)) * **transformers:** Add WithPrimaryKeys option ([#598](#598)) ([107006c](107006c)) ### Bug Fixes * Send resource validation errors to Sentry ([#601](#601)) ([5916516](5916516)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A follow up to cloudquery/cloudquery#6588 where
net.IPwas resolved toTypeByteArrayby the SDK and we had to manually configure it cloudquery/cloudquery@0ccf23bUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)