Skip to content

fix(gitlab): Update to new SDK#6588

Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
erezrokah:fix/update_gitlab
Jan 10, 2023
Merged

fix(gitlab): Update to new SDK#6588
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
erezrokah:fix/update_gitlab

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Jan 10, 2023 •
edited
Loading

Summary

Updates to latest SDK.
Detailed changelog in a markdown comment of this PR ⬇️ (edit this description to see)

@erezrokah erezrokah requested review from a team and candiduslynx and removed request for a team January 10, 2023 14:02
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jan 10, 2023
@cq-bot cq-bot added the gitlab label Jan 10, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • ⚠️ BREAKING CHANGE: Table gitlab_users: column type changed from IntArray to Inet for current_sign_in_ip
  • ⚠️ BREAKING CHANGE: Table gitlab_users: column type changed from IntArray to Inet for last_sign_in_ip

@erezrokah erezrokah changed the title fix: Update to new SDK fix(gitlab): Update to new SDK Jan 10, 2023
@disq
Copy link
Copy Markdown
Member

disq commented Jan 10, 2023

ip address types as int/byte arrays? that's weird when we have a dedicated ip type? the type in the struct is *net.IP.

@erezrokah erezrokah removed the automerge Automatically merge once required checks pass label Jan 10, 2023
@erezrokah
Copy link
Copy Markdown
Member Author

erezrokah commented Jan 10, 2023

ip address types as int/byte arrays? that's weird when we have a dedicated ip type? the type in the struct is *net.IP.

Good catch, fixed in 0ccf23b.

I think this should be done in the SDK as net.IP is a built in type WDYT?

@disq
Copy link
Copy Markdown
Member

disq commented Jan 10, 2023

I think this should be done in the SDK as net.IP is a built in type WDYT?

Definitely, looks like the SDK currently only handles Go primitives and nothing else. Maybe concious decision? Not sure.

@erezrokah erezrokah added automerge Automatically merge once required checks pass priority merge labels Jan 10, 2023
@erezrokah erezrokah mentioned this pull request Jan 10, 2023
Merged
5 tasks
@kodiakhq kodiakhq bot merged commit b821650 into cloudquery:main Jan 10, 2023
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Jan 11, 2023
@erezrokah
feat(transformers): Add support for net.IP (#595)
a420645 


A follow up to cloudquery/cloudquery#6588 where `net.IP` was resolved to `TypeByteArray` by the SDK and we had to manually configure it cloudquery/cloudquery@0ccf23b

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

+1 more reviewer

@candiduslynx candiduslynx candiduslynx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erezrokah @disq @candiduslynx @cq-bot