Skip to content

fix: Fix deadlock off-by-one#493

Merged
kodiakhq[bot] merged 3 commits intomainfrom
fix-deadlock
Dec 13, 2022
Merged

fix: Fix deadlock off-by-one#493
kodiakhq[bot] merged 3 commits intomainfrom
fix-deadlock

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

Fixes a deadlock that occurs with very low concurrency settings. It was an off-by-one error 🤒

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2022

⏱️ Benchmark results

  • DefaultConcurrency-2 resources/s: 11,670
  • Glob-2 ns/op: 197.4
  • TablesWithChildrenDefaultConcurrency-2 resources/s: 29,325
  • BufferedScanner-2 ns/op: 12.23
  • LogReader-2 ns/op: 36.94

@kodiakhq kodiakhq bot merged commit 4ea9ed8 into main Dec 13, 2022
@kodiakhq kodiakhq bot deleted the fix-deadlock branch December 13, 2022 09:02
erezrokah pushed a commit that referenced this pull request Dec 13, 2022
🤖 I have created a release *beep* *boop*
---


##
[1.12.1](v1.12.0...v1.12.1)
(2022-12-13)


### Bug Fixes

* Don't panic on empty-string for timestamp
([#489](#489))
([83813de](83813de))
* Fix deadlock off-by-one
([#493](#493))
([4ea9ed8](4ea9ed8))
* Reduce default concurrency
([#491](#491))
([f995da9](f995da9))
* Refactor glob filters
([#488](#488))
([cb5f6bb](cb5f6bb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants