Merged
Conversation
yevgenypats
approved these changes
Dec 12, 2022
⏱️ Benchmark results
|
erezrokah
pushed a commit
that referenced
this pull request
Dec 13, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.1](v1.12.0...v1.12.1) (2022-12-13) ### Bug Fixes * Don't panic on empty-string for timestamp ([#489](#489)) ([83813de](83813de)) * Fix deadlock off-by-one ([#493](#493)) ([4ea9ed8](4ea9ed8)) * Reduce default concurrency ([#491](#491)) ([f995da9](f995da9)) * Refactor glob filters ([#488](#488)) ([cb5f6bb](cb5f6bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Dec 29, 2022
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary I reduced this in cloudquery/plugin-sdk#491 and forgot to update the docs <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Test locally on your own infrastructure - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When plugins have many tables, like the new Azure plugin we quickly run into memory issues with the current default.
This works on my machine ™️ with the new Azure plugin
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)