fix: Improve formatting of newlines in markdown files#492
Merged
kodiakhq[bot] merged 2 commits intomainfrom Dec 18, 2022
Merged
fix: Improve formatting of newlines in markdown files#492kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
⏱️ Benchmark resultsComparing with f995da9
|
erezrokah
approved these changes
Dec 13, 2022
Member
|
Looks great, but if we need more formatting maybe use https://github.com/shurcooL/markdownfmt or https://github.com/DavidAnson/markdownlint with |
Contributor
Author
|
@erezrokah Yup, I looked at those, but it would be a fairly big dependency and I think this does what we need for now. |
yevgenypats
approved these changes
Dec 17, 2022
10acaa0 to
3a740bc
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.6](v1.12.5...v1.12.6) (2022-12-18) ### Bug Fixes * Add better logging/metric per table ([#513](#513)) ([da36396](da36396)) * Improve formatting of newlines in markdown files ([#492](#492)) ([e48ff90](e48ff90)) * Include table name in logs on panic ([#505](#505)) ([a0b8a46](a0b8a46)) * Move source & destination plugin code to separate packages ([#516](#516)) ([6733785](6733785)) * Use correct error codes ([#514](#514)) ([8b53d76](8b53d76)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This neatens the newlines rendered for table docs, so we can no longer get multiple newlines in a row, like here: https://github.com/cloudquery/cloudquery/pull/5547/files#diff-7a51ae50d93ba1ae94ee3a2e3ff898ae0224a0a1cc32cafe0c667ff46cf080e6R1-R8
Closes #454