Skip to content

fix: Include table name in logs on panic#505

Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
disq:fix/better-panic
Dec 16, 2022
Merged

fix: Include table name in logs on panic#505
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
disq:fix/better-panic

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Dec 15, 2022

No description provided.

@disq disq requested a review from yevgenypats as a code owner December 15, 2022 14:38
@github-actions github-actions bot added the fix label Dec 15, 2022
@github-actions
Copy link
Copy Markdown

⏱️ Benchmark results

Comparing with fc9c7ab

  • DefaultConcurrency-2 resources/s: 12,062 ⬆️ 5.18% increase vs. fc9c7ab
  • Glob-2 ns/op: 160.5 ⬆️ 8.91% increase vs. fc9c7ab
  • TablesWithChildrenDefaultConcurrency-2 resources/s: 28,411 ⬇️ 4.14% decrease vs. fc9c7ab
  • BufferedScanner-2 ns/op: 9.389 ⬇️ 10.24% decrease vs. fc9c7ab
  • LogReader-2 ns/op: 30.69 ⬆️ 0.65% increase vs. fc9c7ab

@disq disq added the automerge label Dec 15, 2022
@kodiakhq kodiakhq bot merged commit a0b8a46 into cloudquery:main Dec 16, 2022
@disq disq deleted the fix/better-panic branch December 16, 2022 09:46
kodiakhq bot pushed a commit that referenced this pull request Dec 19, 2022
🤖 I have created a release *beep* *boop*
---


## [1.12.6](v1.12.5...v1.12.6) (2022-12-18)


### Bug Fixes

* Add better logging/metric per table ([#513](#513)) ([da36396](da36396))
* Improve formatting of newlines in markdown files ([#492](#492)) ([e48ff90](e48ff90))
* Include table name in logs on panic ([#505](#505)) ([a0b8a46](a0b8a46))
* Move source & destination plugin code to separate packages ([#516](#516)) ([6733785](6733785))
* Use correct error codes ([#514](#514)) ([8b53d76](8b53d76))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants