fix(errors): Remove usage of codes.Internal#485
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Dec 11, 2022
Merged
fix(errors): Remove usage of codes.Internal#485kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
codes.Internal#485kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark resultsComparing with ad20787
|
yevgenypats
approved these changes
Dec 11, 2022
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.0](v1.11.2...v1.12.0) (2022-12-11) ### Features * Add handling for json.Number in faker ([#481](#481)) ([ad20787](ad20787)) ### Bug Fixes * Allow both 'yml' and 'yaml' extensions ([#476](#476)) ([52c4c56](52c4c56)) * **errors:** Remove usage of `codes.Internal` ([#485](#485)) ([62692b9](62692b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #462 and also #477.
Two reasons for this change:
codes.Internalas it's generated internally by gRPC so we won't be able to distinguish between gRPC protocol errors and application level errors, see https://github.com/grpc/grpc-go/blob/eeb9afa1f6b6388152955eeca8926e36ca94c768/codes/codes.go#L166.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)