-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Return application level errors as a part of the gRPC response #462
Copy link
Copy link
Closed
Description
TLDR: We should consider having application level errors as a part of the gRPC responses, to make it easier to identify them.
For example in the following line:
plugin-sdk/clients/destination.go
Line 303 in ab7ca97
| return fmt.Errorf("failed to CloseAndRecv client: %w", err) |
failed to CloseAndRecv is not necessarily correct, as err is whatever is returned from the following function:| func (s *DestinationServer) Write2(msg pb.Destination_Write2Server) error { |
Not sure what's the best solution (need to do some research), but we could add an error(s) field to gRPC responses so we have a clear separation between application level errors and gRPC/communication level ones.
Also due to grpc/grpc-go#2934 we can't unwrap errors.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels