Skip to content

fix: Skip relations when initializing metrics#469

Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:fix/map_write_follow_up
Dec 7, 2022
Merged

fix: Skip relations when initializing metrics#469
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:fix/map_write_follow_up

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Dec 7, 2022

Summary

Follow up on #467 (comment)


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions github-actions bot added the fix label Dec 7, 2022
@github-actions github-actions bot added fix and removed fix labels Dec 7, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2022

⏱️ Benchmark results

Comparing with ebef24a

  • DefaultConcurrency-2 resources/s: 11,926 ⬆️ 3.00% increase vs. ebef24a
  • Glob-2 ns/op: 160.5 ⬆️ 6.92% increase vs. ebef24a
  • TablesWithChildrenDefaultConcurrency-2 resources/s: 31,190
  • BufferedScanner-2 ns/op: 9.409 ⬆️ 1.38% increase vs. ebef24a
  • LogReader-2 ns/op: 30.78 ⬆️ 0.78% increase vs. ebef24a

@kodiakhq kodiakhq bot merged commit 5efe564 into cloudquery:main Dec 7, 2022
kodiakhq bot pushed a commit that referenced this pull request Dec 7, 2022
🤖 I have created a release *beep* *boop*
---


## [1.11.1](v1.11.0...v1.11.1) (2022-12-07)


### Bug Fixes

* **codegen:** Column type for slices ([7474c90](7474c90))
* Concurrent read,write to a map ([#467](#467)) ([ebef24a](ebef24a))
* **sentry:** Use HTTPSyncTransport, remove flush ([#465](#465)) ([4d48306](4d48306))
* Skip relations when initializing metrics ([#469](#469)) ([5efe564](5efe564))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah added a commit to erezrokah/plugin-sdk that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants