fix(sentry): Use HTTPSyncTransport, remove flush#465
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Dec 6, 2022
Merged
fix(sentry): Use HTTPSyncTransport, remove flush#465kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark results
|
disq
approved these changes
Dec 6, 2022
Member
disq
left a comment
There was a problem hiding this comment.
Once we verify this is the fix and start getting the panic reports again, we can do another pass to optimize (maybe fall back to HTTPTransport without the sync, but do a blocking Flush() in critical points etc)
yevgenypats
approved these changes
Dec 6, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
🤖 I have created a release *beep* *boop* --- ## [1.11.1](v1.11.0...v1.11.1) (2022-12-07) ### Bug Fixes * **codegen:** Column type for slices ([7474c90](7474c90)) * Concurrent read,write to a map ([#467](#467)) ([ebef24a](ebef24a)) * **sentry:** Use HTTPSyncTransport, remove flush ([#465](#465)) ([4d48306](4d48306)) * Skip relations when initializing metrics ([#469](#469)) ([5efe564](5efe564)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches Sentry to work in synchronous mode (like we have in the CLI).
We can't rely on
sentry.Flushbegin called in a consistent way, especially on Windows since it doesn't support sending an interrupt signal and kills the process immediately:plugin-sdk/clients/source_terminate_windows.go
Line 6 in 464f75f
This might have a performance tradeoff, but since we use it for errors/panics only we think that should be ok.
Another solution @disq suggested would be to call
sentry.Flushafter thesyncfor example in source plugins.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)