fix(test): Values check test should account for IgnoreInTests column option#431
Merged
kodiakhq[bot] merged 6 commits intomainfrom Nov 25, 2022
Merged
fix(test): Values check test should account for IgnoreInTests column option#431kodiakhq[bot] merged 6 commits intomainfrom
IgnoreInTests column option#431kodiakhq[bot] merged 6 commits intomainfrom
Conversation
IgnoreInTests column option should be accounted for values check testIgnoreInTests column option
hermanschaaf
approved these changes
Nov 24, 2022
yevgenypats
suggested changes
Nov 24, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Given it affects all plugin testing. we should have a test for that :)
eb55918 to
090d8ef
Compare
⏱️ Benchmark resultsComparing with 9882458
|
hermanschaaf
approved these changes
Nov 24, 2022
yevgenypats
suggested changes
Nov 24, 2022
5921f53 to
bd80026
Compare
yevgenypats
approved these changes
Nov 24, 2022
hermanschaaf
approved these changes
Nov 25, 2022
bd80026 to
5ef5e7a
Compare
candiduslynx
pushed a commit
that referenced
this pull request
Nov 25, 2022
🤖 I have created a release *beep* *boop* --- ## [1.8.2](v1.8.1...v1.8.2) (2022-11-25) ### Bug Fixes * **test:** Values check test should account for `IgnoreInTests` column option ([#431](#431)) ([ffffcd5](ffffcd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.