fix: SDK compile error, and add workflow (#234)

yevgenypats · web-flow · commit 6ab1dc24c683 · 2022-10-03T20:45:23.000+03:00
#### Summary

Seems we need to add a build step as otherwise we ship passing test but
broken version 🤔
diff --git a/.github/workflows/unittest.yml b/.github/workflows/unittest.yml
@@ -10,28 +10,15 @@ jobs:
   unitests:
     runs-on: ubuntu-latest
     steps:
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v3
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
           go-version: 1.19
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
-      - uses: actions/cache@v3
-        with:
-          # In order:
-          # * Module download cache
-          # * Build cache (Linux)
-          # * Build cache (Mac)
-          # * Build cache (Windows)
-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            ~/Library/Caches/go-build
-            ~\AppData\Local\go-build
-          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
+          cache: true
       - run: go mod download
+      - run: go build ./...
       - name: Run tests
         run: go test -coverprofile=coverage.out ./...
       - name: Generate coverage report
diff --git a/plugins/destination.go b/plugins/destination.go
@@ -51,6 +51,14 @@ func NewDestinationPlugin(name string, version string, newDestinationClient NewD
 	return p
 }
 
+func (p *DestinationPlugin) Name() string {
+	return p.name
+}
+
+func (p *DestinationPlugin) Version() string {
+	return p.version
+}
+
 // we need lazy loading because we want to be able to initialize after
 func (p *DestinationPlugin) Init(ctx context.Context, logger zerolog.Logger, spec specs.Destination) error {
 	var err error
@@ -63,14 +71,6 @@ func (p *DestinationPlugin) Init(ctx context.Context, logger zerolog.Logger, spe
 	return nil
 }
 
-func (p *DestinationPlugin) Name() string {
-	return p.name
-}
-
-func (p *DestinationPlugin) Version() string {
-	return p.version
-}
-
 // we implement all DestinationClient functions so we can hook into pre-post behavior
 func (p *DestinationPlugin) Migrate(ctx context.Context, tables schema.Tables) error {
 	if p.client == nil {
diff --git a/schema/meta.go b/schema/meta.go
@@ -20,9 +20,9 @@ type Meta struct {
 const FetchIDMetaKey = "cq_fetch_id"
 
 var CqIDColumn = Column{Name: "_cq_id", Type: TypeUUID, Description: "Internal CQ ID of the row", Resolver: cqUUIDResolver()}
-var CqParentIDColumn = Column{Name: "_cq_parent_id", Type: TypeUUID, Description: "Internal CQ ID of the parent row", Resolver: parentCqUUIDResolver()}
-var CqSyncTime = Column{Name: "_cq_sync_time", Type: TypeTimestamp, Description: "Internal CQ row of when sync was started (this will be the same for all rows in a single fetch)"}
-var CqSourceName = Column{Name: "_cq_source_name", Type: TypeString, Description: "Internal CQ row that references the source plugin name data was retrieved"}
+var CqParentIDColumn = Column{Name: "_cq_parent_id", Type: TypeUUID, Description: "Internal CQ ID of the parent row", Resolver: parentCqUUIDResolver(), IgnoreInTests: true}
+var CqSyncTime = Column{Name: "_cq_sync_time", Type: TypeTimestamp, Description: "Internal CQ row of when sync was started (this will be the same for all rows in a single fetch)", IgnoreInTests: true}
+var CqSourceName = Column{Name: "_cq_source_name", Type: TypeString, Description: "Internal CQ row that references the source plugin name data was retrieved", IgnoreInTests: true}
 
 func cqUUIDResolver() ColumnResolver {
 	return func(_ context.Context, _ ClientMeta, r *Resource, c Column) error {
