fix: SDK compile error, and add workflow#234
Merged
yevgenypats merged 1 commit intomainfrom Oct 3, 2022
Merged
Conversation
Contributor
Author
|
Actually Im not even sure what happened now as seems that it does compile. my IDE went crazy apparently |
yevgenypats
pushed a commit
that referenced
this pull request
Oct 3, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.1](v0.12.0...v0.12.1) (2022-10-03) ### Bug Fixes * SDK compile error, and add workflow ([#234](#234)) ([6ab1dc2](6ab1dc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Member
|
I think linting should fail if it doesn't compile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seems we need to add a build step as otherwise we ship passing test but broken version 🤔