Skip to content

Commit c06edfa

Browse files
feat(carbon-react): remove label from default props (#9731)
* feat(Carbon-React): remove label from default props * feat(Carbon-React): revert Switch.js changes, update overflow menu item Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
1 parent e7b27cf commit c06edfa

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

packages/react/src/components/OverflowMenu/OverflowMenu.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { OverflowMenuVertical16 } from '@carbon/icons-react';
1818
import { keys, matches as keyCodeMatches } from '../../internal/keyboard';
1919
import mergeRefs from '../../tools/mergeRefs';
2020
import { PrefixContext } from '../../internal/usePrefix';
21+
import * as FeatureFlags from '@carbon/feature-flags';
2122

2223
const on = (element, ...args) => {
2324
element.addEventListener(...args);
@@ -97,7 +98,9 @@ class OverflowMenu extends Component {
9798
/**
9899
* The ARIA label.
99100
*/
100-
ariaLabel: PropTypes.string,
101+
ariaLabel: FeatureFlags.enabled('enable-v11-release')
102+
? PropTypes.string.isRequired
103+
: PropTypes.string,
101104

102105
/**
103106
* The child nodes.
@@ -218,7 +221,9 @@ class OverflowMenu extends Component {
218221
static contextType = PrefixContext;
219222

220223
static defaultProps = {
221-
ariaLabel: 'open and close list of options',
224+
ariaLabel: FeatureFlags.enabled('enable-v11-release')
225+
? null
226+
: 'open and close list of options',
222227
iconDescription: 'open and close list of options',
223228
open: false,
224229
direction: DIRECTION_BOTTOM,

packages/react/src/components/OverflowMenuItem/OverflowMenuItem.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import React from 'react';
1212
import { match, keys } from '../../internal/keyboard';
1313
import { warning } from '../../internal/warning';
1414
import deprecate from '../../prop-types/deprecate.js';
15+
import * as FeatureFlags from '@carbon/feature-flags';
1516

1617
const { prefix } = settings;
1718

@@ -100,7 +101,9 @@ export default class OverflowMenuItem extends React.Component {
100101
hasDivider: false,
101102
isDelete: false,
102103
disabled: false,
103-
itemText: 'Provide itemText',
104+
itemText: FeatureFlags.enabled('enable-v11-release')
105+
? null
106+
: 'Provide itemText',
104107
onClick: () => {},
105108
onKeyDown: () => {},
106109
};

0 commit comments

Comments
 (0)