feat(carbon-react): remove label from default props#9731
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 6b1f12a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/618982ff5bd07900080897a7 😎 Browse the preview: https://deploy-preview-9731--carbon-react-next.netlify.app/ |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6b1f12a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/618982ff41e4d10007051c2b 😎 Browse the preview: https://deploy-preview-9731--carbon-components-react.netlify.app/ |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6b1f12a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618982ff5bfd7300080e6a49 😎 Browse the preview: https://deploy-preview-9731--carbon-elements.netlify.app |
abbeyhrt
left a comment
There was a problem hiding this comment.
Looks good to me! I think there was another one in OverflowMenuItem that needs to be updated too
| ariaLabel: FeatureFlags.enabled('enable-v11-release') | ||
| ? PropTypes.string.isRequired | ||
| : PropTypes.string, |
There was a problem hiding this comment.
In this component, are we looking for ariaLabel or iconDescription to be the accessibility label for the component?
There was a problem hiding this comment.
I figured iconDescription was not necessarily the accessibility label
There was a problem hiding this comment.
it could be specified but we would still allow a default?
joshblack
left a comment
There was a problem hiding this comment.
Sorry I blanked on this! Looks good
abbeyhrt
left a comment
There was a problem hiding this comment.
Ah sorry! Looks good to me, sorry for ignoring it for so long!
partially closes #9466
Removes various labelling from
defaultPropsfor v11 🏄🏾Changelog
Changed
Testing / Reviewing
In a v11 feature flagged environment test and see (via the Storys i'd suppose) if omitting proper labeling causes a console error from React 🦖
attn @abbeyhrt