This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ac5af5:

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47047/

Could you run core-js-compat test case and add a PR to core-js too?

Could you run core-js-compat test case and add a PR to core-js too?

Unfortunately Rhino can't really even run the test runner core-js uses (at least via my naive attempt). Would it be ok to merge this before getting that sorted or are they both needed concurrently?

@gausie you could check the source of the test runner and adapt it to Rhino - it's just some lines. It's required for proper built-ins injection by preset-env, however, it's not a block for this PR.

@zloirock Sure, I'll adapt in my local copy for rhino, get the data and discard my edits.

@gausie you could add a Rhino runner to the PR like in compat-table - it could simplify adding new data in the future -)

@gausie you could add a Rhino runner to the PR like in compat-table - it could simplify adding new data in the future -)

I think I'll just fix the two issues in Rhino!

Here's that PR: zloirock/core-js#942

@zloirock whats up with these two in-progress ci jobs? Are they waiting for approval to start somehow?

I think that it could be better to ask @nicolo-ribaudo since I'm not an expert in current CI.

We only run them manually when changing code that only affects Babel 8 or that might affect spec compliancy of our plugin.

Ahha! Well this ain't that 😛

We need to bump core-js-compat when zloirock/core-js#942 is published.

@JLHwung that has now landed in core-js v3.15.0

Ok I've bumped core-js-compat but unsure if I should have bumped core-js too, so I've left it.

@gausie I'm preparing a PR to bump all the core-js packages. I prefer to keep it separate from this one because this PR will be merged in the next minor, while bumping core-js is more urgent otherwise our e2e tests will start failing.

@nicolo-ribaudo ok, is bumping core-js-compat as I have done ok, or should I undo that last commit?

We'll ask you to rebase this PR on main after #13491 is merged (or to merge main in this PR), so reverting the last commit is not necessary but might make it easier to rebase later.

I just saw compat-table/compat-table#1731. Maybe for the same reason we should have Rhino patch versions in our data? We might need to update our build script to support them.

@nicolo-ribaudo Adding in that patch release is easy since every 1.7 would just need the same change, but I'm not sure how I'd go about updating the build scripts.

Mmh, looking at our build script it looks like it should already work 🤔 Could you try updating the COMPAT_TABLE hash, and let's see if it works.

Btw, we just merged #13491 into main.

@nicolo-ribaudo Ok that's all done now

Does rhino support ES Modules? I searched its repo and it seems to me rhino only supports commonjs. If I am wrong, we should also update packages/babel-compat-data/scripts/build-modules-support.js, otherwise this PR lgtm.

You're correct, for now it only supports commonjs. Woop!

We'll release 7.15 this week. Thank you!