Add compat data for rhino JS engine#942
Merged
zloirock merged 1 commit intozloirock:masterfrom Jun 10, 2021
Merged
Conversation
Owner
|
Thanks -) |
Owner
|
(never mind - found the answer) |
Contributor
Author
|
Excellent! |
zloirock
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get this running on the current version of Rhino I needed to:
GLOBALintests.jsto equalglobalconsole.logwithprintfalsefor "es.string.search" because the code causes an NPEThese (in particular number 3) are good little tasks to fix upstream in Rhino though
Then it ran no problem with
java -jar rhino.jar -version 200 -require ./node-runner.js