[Patch port] fix(compiler-cli): emitting references to ngtypecheck files (#57138)#57202
Closed
crisbeto wants to merge 1 commit intoangular:18.1.xfrom
Closed
[Patch port] fix(compiler-cli): emitting references to ngtypecheck files (#57138)#57202crisbeto wants to merge 1 commit intoangular:18.1.xfrom
crisbeto wants to merge 1 commit intoangular:18.1.xfrom
Conversation
…57138) Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`. Fixes angular#57135. PR Close angular#57138
Member
Author
|
Caretaker note: since this is just cherry-picking #57138, I've skipped PullApprove. |
thePunderWoman
approved these changes
Jul 31, 2024
Contributor
|
This PR was merged into the repository by commit 1f9e090. The changes were merged into the following branches: 18.1.x |
This was referenced Aug 22, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a patch port of #57138.
Follow-up to #56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to
NgCompiler.prepareEmitwhich seems to cover a bit more comared toNgtscProgram.emit.Fixes #57135.