fix(compiler-cli): avoid emitting references to typecheck files in TS 5.4 #56961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 5.4 In angular#56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes angular#56945.
JoostK
approved these changes
Jul 12, 2024
Contributor
|
This PR was merged into the repository by commit f0d6d06. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 15, 2024
… 5.4 (#56961) In #56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes #56945. PR Close #56961
|
Had the same problem, so I have waited for the fix in 18.1.1, but the fix don't work with ts 5.4.5, so I have upgraded to ts 5.5.3 and all works. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 26, 2024
Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`. Fixes angular#57135.
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…57138) Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`. Fixes angular#57135. PR Close angular#57138
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 31, 2024
…57138) Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`. Fixes angular#57135. PR Close angular#57138
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references.
These changes add tagging right before the program emits.
Fixes #56945.