I'm wondering if we should just check if the current platform is server and exit in this case:

I think that was the intention of the window-based check.

I kept it because this.window is typed as Window | null, should we change the typing ?

Thanks for additional information. In this case we can move this check to the constructor:

    if (!this.isServer && typeof win !== 'undefined') {
      this.window = win;
    }

So we set the window reference only when we are not on the server. What do you think?

@JeanMeche, I understand you didn't originally work on this part, but there's an issue with how we're obtaining the base href, and it also highlights a couple of other issues.

1. We're currently using the Window object, which is incorrect. Instead, we should be using the PlatformLocation service. This service will return the correct base when running on the server. When an absolute URL is provided, the PlatformLocation service handles it correctly.
2. When a relative URL is provided in the server config, we're currently setting the base href to /, which is not valid, as you pointed out. This setting lacks a protocol and makes the href invalid.

   angular/packages/platform-server/src/domino_adapter.ts

   Line 24 in 101edda

   export function parseDocument(html: string, url = '/') {

Maybe the getURL function should be updated to use a base instead of a Window object:

export function getUrl(src: string, base: string): URL

This approach is essentially equivalent to using new URL(), because if src is absolute, new URL(src) yields the same result as new URL(src, win.location.href).

@alan-agius4 quick question: the change is in this PR should make this service a noop on the server (only be invoked in a browser). Would you recommend changing the mentioned logic anyway?

I agree that accessing the window global isn't great. I've refactored to use PlatformLocation.