Skip to content

Revert "fix(common): Don't run preconnect assertion on the server. (#56213)" #56740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 1 commit into from
Closed

Revert "fix(common): Don't run preconnect assertion on the server. (#56213)" #56740

AndrewKushnir wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jun 27, 2024

This reverts commit 39e48ce.

Reason for the revert: breaks some internal targets.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release common: image directive labels Jun 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 27, 2024
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jun 27, 2024

Presubmit.

@AndrewKushnir AndrewKushnir mentioned this pull request Jun 27, 2024
Closed
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 27, 2024
thePunderWoman pushed a commit that referenced this pull request Jun 27, 2024
@AndrewKushnir @thePunderWoman
Revert "fix(common): Don't run preconnect assertion on the server. (#…
62970ca 
…56213)" (#56740)

This reverts commit 39e48ce.

PR Close #56740
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jun 27, 2024

This PR was merged into the repository by commit 3447753.

The changes were merged into the following branches: main, 18.0.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 28, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package common: image directive merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @thePunderWoman