feat(compiler-cli): support multiple configuration files in extends
#49125
Conversation
|
Blocked on #49107 |
f95b4c1 to
7785571
Compare
TypeScript 5 support `extends` to be an array, this commit adds support to allow extending `angularCompilerOptions` from multiple config files. See: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#supporting-multiple-configuration-files-in-extends
7785571 to
602f492
Compare
| })); | ||
| }); | ||
|
|
||
| it('should merge tsconfig "angularCompilerOptions" when extends is an array', () => { |
There was a problem hiding this comment.
I wonder what the behavior here should be for nested options, extendedDiagnostics being the primary example.
There was a problem hiding this comment.
That doesn’t change with this change. Complex objects such as paths and extendedDiagnostics ste not merged.
There was a problem hiding this comment.
Do we have a test to that effect? I realise it's more about extends in general than having multiple extends per se, but wouldn't hurt to explicitly capture this behavior in a test.
There was a problem hiding this comment.
We do not, but I can add it if you wish.
There was a problem hiding this comment.
Capturing that behavior would be valuable, IMO
| })); | ||
| }); | ||
|
|
||
| it('should merge tsconfig "angularCompilerOptions" when extends is an array', () => { |
There was a problem hiding this comment.
Capturing that behavior would be valuable, IMO
This commit adds a test case for validate that we do not deep merge objects like like 'paths' and `extendedDiagnostics`.
|
This PR was merged into the repository by commit 1418d19. |
This commit adds a test case for validate that we do not deep merge objects like like 'paths' and `extendedDiagnostics`. PR Close #49125
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
TypeScript 5 support
extendsto be an array, this commit adds support to allow extendingangularCompilerOptionsfrom multiple config files.See: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#supporting-multiple-configuration-files-in-extends