Skip to content

Conversation

@crisbeto
Copy link
Member

No description provided.

Uses an alternate approach of preserving default imports that doesn't involve the `getMutableClone` function that is being removed in TypeScript 5.0.

The alternate approach was already used in the downlevel transform and it works by patching the EmitResolver of the current transformation context to tell TypeScript to preserve the import.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 16, 2023
@ngbot ngbot bot added this to the Backlog milestone Feb 16, 2023
@JoostK
Copy link
Member

JoostK commented Feb 16, 2023

Leaving a note here that we should update our tsconfig.json reading logic to support extends being an array.

@crisbeto crisbeto force-pushed the ts-5 branch 4 times, most recently from 9af7f14 to 03b361a Compare February 17, 2023 08:22
@alan-agius4
Copy link
Contributor

alan-agius4 commented Feb 17, 2023

Leaving a note here that we should update our tsconfig.json reading logic to support extends being an array.

I already have the code ready for that. Was waiting for TS 5 support to land. (#49125)

Tests updating to TypeScript 5.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: build & ci Related the build and CI infrastructure of the project state: WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants