feat(connect): update default behavior to be cli-only#3487
Merged
brandtkeller merged 11 commits intomainfrom Feb 12, 2025
Merged
feat(connect): update default behavior to be cli-only#3487brandtkeller merged 11 commits intomainfrom
brandtkeller merged 11 commits intomainfrom
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
…lang group across 1 directory (#3485) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
…3483) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
…3486) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
d230061 to
830aab6
Compare
AustinAbro321
approved these changes
Feb 11, 2025
Member
AustinAbro321
left a comment
There was a problem hiding this comment.
LGTM welcome to the club!
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com> Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propose a default
zarf connectworkflow that is not reliant upon an existing system dependency - instead opting for a more headless-friendly approach.Updated a test to not have a hardcoded relative path to
/tmp.Considering documenting this as an element of design for functionality within zarf - IE default workflows (or all workflows) being fully encapsulated logic that do not have external-to-the-binary dependencies.
Related Issue
Fixes #3480
Checklist before merging