Skip to content

feat: improve skeleton package messaging#3482

Merged
AustinAbro321 merged 1 commit intomainfrom
improve-skeleton-publishing-messaging
Feb 7, 2025
Merged

feat: improve skeleton package messaging#3482
AustinAbro321 merged 1 commit intomainfrom
improve-skeleton-publishing-messaging

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

Description

We've heard complaints about skeleton packages being confusing, I expect them to be deprecated and their use case along custom init packages to be replaced some day, but for now I wanted to make it more clear to users that they are publishing a skeleton package and what that means.

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners February 7, 2025 20:36
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 7, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 55e52fc
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67a66eb86daae50008d9ef04
😎 Deploy Preview https://deploy-preview-3482--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AustinAbro321 AustinAbro321 changed the title improve skeleton package publishing feat: improve skeleton package messaging Feb 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/publish.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/publish.go 0.00% <0.00%> (ø)

Copy link
Copy Markdown
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 8be4420 Feb 7, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the improve-skeleton-publishing-messaging branch February 7, 2025 21:26
brandtkeller pushed a commit that referenced this pull request Feb 10, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants