Update FeatureContext::$result and FeatureContext::$email_sends visibility#170
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom May 8, 2023
thelovekesh:fix/property-visibility
Merged
Update FeatureContext::$result and FeatureContext::$email_sends visibility#170danielbachhuber merged 1 commit intowp-cli:mainfrom thelovekesh:fix/property-visibility
FeatureContext::$result and FeatureContext::$email_sends visibility#170danielbachhuber merged 1 commit intowp-cli:mainfrom
thelovekesh:fix/property-visibility
Conversation
…roperty visibility to protected
Member
Author
|
Please check ampproject/amp-wp#7530 where we found it initially. For error logs please refer to GHA runner logs here. |
danielbachhuber
approved these changes
May 8, 2023
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Sorry about breaking that for you! I'll tag a new release for this.
FYI @mrsdizzie (no worries, just wanted to let you know)
wojsmol
pushed a commit
to wojsmol/wp-cli-tests
that referenced
this pull request
Jun 3, 2023
…roperty visibility to protected (wp-cli#170)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FeatureContext::$resultandFeatureContext::$email_sendsproperties were defined with private visibility as part of #165, which is now preventing the child class from using them in the event that more step definitions are added.This PR seeks to restore the previous functionality, in which the child class was permitted access to the properties listed above.