Skip to content

Bump wp-cli/wp-cli-tests from 3.2.1 to 3.2.5#7530

Closed
dependabot[bot] wants to merge 2 commits intodevelopfrom
dependabot/composer/wp-cli/wp-cli-tests-3.2.5
Closed

Bump wp-cli/wp-cli-tests from 3.2.1 to 3.2.5#7530
dependabot[bot] wants to merge 2 commits intodevelopfrom
dependabot/composer/wp-cli/wp-cli-tests-3.2.5

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 18, 2023

Bumps wp-cli/wp-cli-tests from 3.2.1 to 3.2.5.

Release notes

Sourced from wp-cli/wp-cli-tests's releases.

Version 3.2.5

  • Use TEST_USER instead of TEST_DB [#169]

Version 3.2.4

  • Use POSIX-compatible counter incrementing [#168]

Version 3.2.3

  • Update install-package-tests to wait until MySQL is ready to accept connections [#167]
  • Avoid error when using composer behat -- --help [#166]

Version 3.2.2

  • Fix PHP 8.2 deprecation warnings [#165]
Commits
  • ea27e6e Using TEST_DB where it should be TEST_USER (#169)
  • 2e31d19 Use POSIX-compatible counter incrementing (#168)
  • a8513f9 Update install-package-tests to wait until MySQL is ready to accept connectio...
  • 740af0d Avoid error when using composer behat -- --help (#166)
  • c606e43 Fix PHP 8.2 deprecation warnings (#165)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Apr 18, 2023
@westonruter westonruter added this to the v2.4.2 milestone Apr 18, 2023
@westonruter
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/wp-cli/wp-cli-tests-3.2.5 branch from 163057c to 17bff8c Compare April 18, 2023 20:48
@westonruter
Copy link
Member

@thelovekesh Would you look into the feature test failures?

@thelovekesh
Copy link
Collaborator

Seems like this line here causing the issue:

https://github.com/wp-cli/wp-cli-tests/blob/ea27e6e6293871e687331f42db30bef7f952ffa0/bin/install-package-tests#L51

Somehow it's unable to determine the host and port. When I edited it to:

while ! mysql --user="${USER}" "${PASSWORD_STRING}" ${HOST_STRING} --execute="SHOW DATABASES;" | grep 'information_schema' >/dev/null;

it works as expected,

@westonruter Should I file an issue?

@westonruter
Copy link
Member

@thelovekesh I suppose so. Is this a regression? Perhaps due to wp-cli/wp-cli-tests#169?

@thelovekesh thelovekesh force-pushed the dependabot/composer/wp-cli/wp-cli-tests-3.2.5 branch 2 times, most recently from 98fa5f2 to 99507d5 Compare April 20, 2023 05:28
@thelovekesh
Copy link
Collaborator

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 20, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@thelovekesh
Copy link
Collaborator

@dependabot recreate

Bumps [wp-cli/wp-cli-tests](https://github.com/wp-cli/wp-cli-tests) from 3.2.1 to 3.2.5.
- [Release notes](https://github.com/wp-cli/wp-cli-tests/releases)
- [Commits](wp-cli/wp-cli-tests@v3.2.1...v3.2.5)

---
updated-dependencies:
- dependency-name: wp-cli/wp-cli-tests
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/wp-cli/wp-cli-tests-3.2.5 branch from 3f47dcb to 1f54bbb Compare April 20, 2023 06:21
@thelovekesh
Copy link
Collaborator

@westonruter Correctly setting up MYSQL_TCP_PORT solves the issues. But this new version, tests with Then STDERR should be statements are breaking with an error:

Scenario: List option with invalid user capability # tests/features/option-list-command.feature:6
    When I try the WP-CLI command `amp option list`  # AmpProject\AmpWP\Tests\Behat\FeatureContext::when_i_run_the_wp_cli_command()
    Then STDERR should be:                           # AmpProject\AmpWP\Tests\Behat\FeatureContext::then_stdout_stderr_should_contain()
      """
      Error: Sorry, you are not allowed to manage options for the AMP plugin for WordPress.
      Try using --user=<id|login|email> to set the user context or set it in wp-cli.yml.
      """
      Warning: Attempt to read property "stderr" on null in vendor/wp-cli/wp-cli-tests/src/Context/ThenStepDefinitions.php line 36
    And STDOUT should be empty                       # AmpProject\AmpWP\Tests\Behat\FeatureContext::then_stdout_stderr_should_be_empty()
    And the return code should be 1                  # AmpProject\AmpWP\Tests\Behat\FeatureContext::then_the_return_code_should_be()

Somehow $this->result is coming up as null in then_stdout_stderr_should_contain().

@thelovekesh
Copy link
Collaborator

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2023

Superseded by #7547.

@dependabot dependabot bot closed this May 9, 2023
@dependabot dependabot bot deleted the dependabot/composer/wp-cli/wp-cli-tests-3.2.5 branch May 9, 2023 15:32
@thelovekesh thelovekesh added the Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency. label May 9, 2023
@westonruter westonruter removed this from the v2.4.2 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file php Pull requests that update Php code Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants