Skip to content

feat: do not attach prefs when debuggerAddress is specified#14634

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
uladhsi:main
Jul 14, 2025
Merged

feat: do not attach prefs when debuggerAddress is specified#14634
christian-bromann merged 1 commit intowebdriverio:mainfrom
uladhsi:main

Conversation

@uladhsi
Copy link
Contributor

@uladhsi uladhsi commented Jul 14, 2025 •
edited
Loading

Proposed changes

Disable attaching prefs object to the 'goog:chromeOptions' when the debuggerAddress is specified, because chrome.prefs are supposed to be used for a new session, and debuggerAddress is used when there is an intention to connect to an existing session.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

Further comments

Related issue: #14591

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 14, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@uladhsi uladhsi marked this pull request as draft July 14, 2025 13:28
@uladhsi uladhsi mentioned this pull request Jul 14, 2025
Merged
11 tasks
@uladhsi uladhsi marked this pull request as ready for review July 14, 2025 14:31
christian-bromann
christian-bromann approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jul 14, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 14, 2025

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14634

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14634

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14634

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14634

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14634

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14634

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14634

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14634

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14634

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14634

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14634

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14634

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14634

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14634

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14634

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14634

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14634

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14634

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14634

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14634

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14634

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14634

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14634

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14634

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14634

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14634

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14634

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14634

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14634

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14634

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14634

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14634

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14634

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14634

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14634

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14634

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14634

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14634

commit: ec3409b

@christian-bromann christian-bromann merged commit b4e3884 into webdriverio:main Jul 14, 2025
75 of 76 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Jul 14, 2025

Hey uladhsi 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uladhsi @wdio-bot @christian-bromann