feat: do not attach prefs when debuggerAddress is specified (v8)#14635
Merged
christian-bromann merged 2 commits intowebdriverio:v8from Jul 14, 2025
Merged
feat: do not attach prefs when debuggerAddress is specified (v8)#14635christian-bromann merged 2 commits intowebdriverio:v8from
christian-bromann merged 2 commits intowebdriverio:v8from
Conversation
13 tasks
Contributor
Author
|
@christian-bromann is there any plan when this is going to be released for v8? |
Member
|
Thanks for pinging, I just triggered a v8 release. |
Contributor
Author
|
@christian-bromann thanks for triggering it, but somehow it did not get released. There was a failure during the release, could you take a look if possible? https://github.com/webdriverio/webdriverio/actions/runs/16529089221/job/46749773768 |
Member
|
@uladhsi mhm 🤔 something broke in the pipeline, not sure why. Mind raising an issue for it? |
Contributor
Author
|
@christian-bromann Sure, here it is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Backported PR for #14634
Disable attaching prefs object to the 'goog:chromeOptions' when the
debuggerAddressis specified, becausechrome.prefsare supposed to be used for a new session, anddebuggerAddressis used when there is an intention to connect to an existing session.Types of changes
Checklist
Further comments
Related issue: #14591
Reviewers: @webdriverio/project-committers