Skip to content

fix(webdriverio): properly switch context using switchToParentFrame()#14070

Merged
christian-bromann merged 7 commits intomainfrom
cb/switch-to-parent-frame-fix
Jan 17, 2025
Merged

fix(webdriverio): properly switch context using switchToParentFrame()#14070
christian-bromann merged 7 commits intomainfrom
cb/switch-to-parent-frame-fix

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 13, 2025 •
edited
Loading

Proposed changes

fixes #14064
fixes #14070

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 13, 2025
@christian-bromann christian-bromann mentioned this pull request Jan 13, 2025
Closed
3 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 13, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14070

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14070

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14070

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14070

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14070

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14070

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14070

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14070

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14070

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14070

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14070

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14070

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14070

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14070

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14070

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14070

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14070

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14070

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14070

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14070

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14070

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14070

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14070

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14070

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14070

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14070

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14070

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14070

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14070

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14070

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14070

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14070

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14070

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14070

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14070

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14070

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14070

commit: 0c545dc

@christian-bromann christian-bromann mentioned this pull request Jan 13, 2025
Closed
3 tasks
erwinheitzman
erwinheitzman approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it but did add two suggestions that you could pickup if you feel like they add value

christian-bromann and others added 6 commits January 17, 2025 10:33
@christian-bromann
fix(webdriverio): properly switch context using switchToParentFrame()
1c930f1
@christian-bromann
fix e2e test
791c01c
@christian-bromann
fix unit test
638a4a7
@christian-bromann
revert wrong change
327630d
@christian-bromann @Delta456
fix(webdriverio): allow to take screenshots of frames (#14071)
4d95044 
* fix(webdriverio): allow to take screenshots of frames

* Update packages/webdriverio/src/commands/browser/saveScreenshot.ts

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>

---------

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>
@christian-bromann
fix(webdriverio): properly switch context using switchToParentFrame()
df953d3
@christian-bromann christian-bromann force-pushed the cb/switch-to-parent-frame-fix branch from 67968e1 to df953d3 Compare January 17, 2025 18:34
@christian-bromann christian-bromann merged commit 33a1b19 into main Jan 17, 2025
@christian-bromann christian-bromann deleted the cb/switch-to-parent-frame-fix branch January 17, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: switchToParentFrame switches to the top-level browsing context (root) instead of (only) the parent frame.

2 participants

@christian-bromann @erwinheitzman