Skip to content

fix(webdriverio): allow to take screenshots of frames#14071

Merged
christian-bromann merged 4 commits intocb/switch-to-parent-frame-fixfrom
cb/parentFrameScreenshot
Jan 17, 2025
Merged

fix(webdriverio): allow to take screenshots of frames#14071
christian-bromann merged 4 commits intocb/switch-to-parent-frame-fixfrom
cb/parentFrameScreenshot

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 13, 2025

Proposed changes

fixes #14065

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 13, 2025
@christian-bromann christian-bromann changed the title fix(webdriverio): properly switch context using switchToParentFrame() fix(webdriverio): allow to take screenshots of frames Jan 13, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 13, 2025 •
edited
Loading

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14071

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14071

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14071

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14071

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14071

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14071

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14071

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14071

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14071

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14071

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14071

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14071

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14071

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14071

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14071

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14071

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14071

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14071

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14071

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14071

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14071

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14071

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14071

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14071

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14071

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14071

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14071

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14071

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14071

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14071

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14071

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14071

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14071

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14071

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14071

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14071

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14071

commit: 9ad67c7

Delta456
Delta456 reviewed Jan 14, 2025
View reviewed changes
@christian-bromann @Delta456
Update packages/webdriverio/src/commands/browser/saveScreenshot.ts
8cd000f 
Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>
@christian-bromann christian-bromann mentioned this pull request Jan 15, 2025
Closed
3 tasks
erwinheitzman
erwinheitzman approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit 088e7a1 into cb/switch-to-parent-frame-fix Jan 17, 2025
@christian-bromann christian-bromann deleted the cb/parentFrameScreenshot branch January 17, 2025 18:28
christian-bromann added a commit that referenced this pull request Jan 17, 2025
@christian-bromann @Delta456
fix(webdriverio): allow to take screenshots of frames (#14071)
4d95044 
* fix(webdriverio): allow to take screenshots of frames

* Update packages/webdriverio/src/commands/browser/saveScreenshot.ts

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>

---------

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>
christian-bromann added a commit that referenced this pull request Jan 17, 2025
@christian-bromann @Delta456
fix(webdriverio): properly switch context using switchToParentFrame() (…
33a1b19 
…#14070)

* fix(webdriverio): properly switch context using switchToParentFrame()

* fix e2e test

* fix unit test

* revert wrong change

* fix(webdriverio): allow to take screenshots of frames (#14071)

* fix(webdriverio): allow to take screenshots of frames

* Update packages/webdriverio/src/commands/browser/saveScreenshot.ts

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>

---------

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>

* fix(webdriverio): properly switch context using switchToParentFrame()

* pr feedback

---------

Co-authored-by: Swastik Baranwal <swstkbaranwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman approved these changes

+1 more reviewer

@Delta456 Delta456 Delta456 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-bromann @erwinheitzman @Delta456